Differences

This shows you the differences between two versions of the page.

--- creating:safety [2025/08/27 18:46] – Created page with intro and first section ahelwer
+++ creating:safety [2025/11/03 23:16] (current) – Removed extra line of code ahelwer
@@ Line 13: / Line 13: @@
 Safety properties are often informally described as "nothing bad happens" properties, also called //invariants//.
 For example, when developing a multi-core CPU memory caching system, a good safety property would be that no two CPU caches ever disagree about the value stored at a given memory address.
-However, our systems often surprise us and find their ways to corners of the state space where a safety property does not hold.
+However, our systems often surprise us and find their way to corners of the state space where a safety property does not hold.
 When that happens, the best way to debug the problem is to see a path from some initial state to the state violating the invariant.
 This path is what is meant by a state trace counterexample of finite length.
@@ Line 27: / Line 27: @@
 Our overall approach to checking safety properties has the following structure:
-  - Parse a TLA⁺ specification, identifying the ''Init'', ''Next'', and ''Inv'' definitions.
+  - Parse a TLA⁺ specification, identifying ''Init'', ''Next'', and the invariants.
   - Find the spec's initial state(s) satisfying ''Init''.
   - Repeatedly use ''Next'' to find all states in the system following from the initial state(s).
-  - Check to ensure the ''Inv'' invariant holds in every discovered state.
+  - Check to ensure the invariants hold in every discovered state.
-  - If a state violates ''Inv'', construct a state trace leading from some initial state to the violating state.
+  - If a state violates an invariant, construct a state trace leading from some initial state to the violating state.
 For this purpose, create a new file ''ModelChecker.java'' and pre-emptively import all the datastructures we'll need.
@@ Line 56: / Line 56: @@
 The real TLA⁺ tools allow users to identify the init, next and invariant predicates in a model configuration file.
-We skip all that and simply require our specs to have operator definitions named ''Init'', ''Next'', and ''Inv''.
+We skip all that and simply require our specs to have operator definitions named ''Init'', ''Next'', and a few options for invariants.
 Iterate through all the spec statements to find them:
-<code java [highlight_lines_extra="2,3,4,8,9,10,11,12,13,14,15,16,17"]>
+<code java [highlight_lines_extra="2,3,4,8,9,10,11,12,13,14,15,16,17,18"]>
   private final Interpreter interpreter;
   private Stmt.OpDef init = null;
   private Stmt.OpDef next = null;
-  private Stmt.OpDef invariantDef = null;
+  private List<Stmt.OpDef> invariants = new ArrayList<>();
   ModelChecker(Interpreter interpreter, List<Stmt> spec) {
     this.interpreter = interpreter;
     for (Stmt unit : spec) {
-      if (unit instanceof Stmt.OpDef) {
+      if (unit instanceof Stmt.OpDef op) {
-        Stmt.OpDef op = (Stmt.OpDef)unit;
         switch (op.name.lexeme) {
-          case "Init"   : this.init = op;
+          case "Init"   -> init = op;
-          case "Next"   : this.next = op;
+          case "Next"   -> next = op;
-          case "Inv"    : this.invariantDef = op;
+          case "Inv"    -> invariants.add(op);
+          case "TypeOK" -> invariants.add(op);
+          case "Safety" -> invariants.add(op);
         }
       }
@@ Line 97: / Line 98: @@
 Then add calls to ''validate()'' at the bottom of our ''ModelChecker'' constructor:
 <code java [highlight_lines_extra="1,2,3"]>
-    validate(this.init, "Init");
+    validate(init, "Init");
-    validate(this.next, "Next");
+    validate(next, "Next");
-    validate(this.invariantDef, "Inv");
+    for (Stmt.OpDef inv : invariants) validate(inv, inv.name.lexeme);
   }
 </code>
+As written it is possible for users to define no invariants at all, which is fine.
 Step one complete!
-===== Finding the Initial States =====
+===== Exploring the State Space =====
-Now we kick off the main event.
+Now for the main event - everything has led up to this!
-Define a new ''checkSafety()'' method in the ''ModelChecker'' class:
+Create a new ''checkSafety()'' method in the ''ModelChecker'' class:
 <code java>
-  List<Map<String, Object>> checkSafety() {
+  StateTrace checkSafety() {
     return null;
@@ Line 116: / Line 117: @@
 </code>
-This method indicates success (the invariant held in every state) by returning ''null''.
+This method indicates success (the invariants holds in every state) by returning ''null''.
-If the invariant does not hold in every state, the method returns a state trace leading to the failing state.
+If the invariants do not hold in every state, the method returns a state trace leading to the failing state.
+Define the ''StateTrace'' record near the top of the ''ModelChecker'' class:
+<code java [highlight_lines_extra="3,4"]>
+class ModelChecker {
+  record Step(String action, Map<String, Object> state) { }
+  record StateTrace(String failingInvariant, List<Step> trace) { }
+  private final Interpreter interpreter;
+</code>
+Let's talk about //how// we are going to explore the state space.
+There are many, many methods of doing this.
+We'll use [[https://en.wikipedia.org/wiki/Breadth-first_search|breadth-first search]] (BFS), which explores the state space like a ripple in a pond moving outward from the initial state(s).
+BFS has the nice property that whenever we first encounter a state, we have also found the shortest path to that state from the initial state(s).
+It works as follows:
+  - Push all initial states onto a queue of pending states, and add them to a set of visited states.
+  - While the pending state queue is not empty, pop the head state from the queue for examination.
+  - Find all next states reachable in one step from the state under examination.
+  - For each next state, if it has not already been visited then push it onto the pending state queue and add it to the set of visited states.
+Not too bad!
+Only two datastructures, a queue to hold the pending states and a set to record all the states we've visited.
+Assuming there are a finite number of states, BFS will eventually examine all states then terminate.
+If there are an infinite number of states - an easy-to-accomplish feat in TLA⁺ - then BFS will never terminate, but that is a user problem.
+There is one more thing we need to keep track of so we can reconstruct state traces: each state's predecessor, the state from which we first stepped to it.
+This combines nicely with the visited set; instead of a set of states, we use a map from states to their predecessors.
+If a state is in the predecessor map, it must have been visited.
+The predecessor of all initial states is ''null''.
+With all that out of the way, here's how we write the preamble to the main BFS loop in ''checkSafety()'':
+<code java [highlight_lines_extra="2,3,4,5,6,7,9,11"]>
+  StateTrace checkSafety() {
+    Deque<Map<String, Object>> pendingStates = new ArrayDeque<>();
+    Map<Map<String, Object>, Map<String, Object>> predecessors = new HashMap<>();
+    for (Map<String, Object> initialState : interpreter.getNextStates(init.name, init.body)) {
+      predecessors.put(initialState, null);
+      pendingStates.add(initialState);
+    }
+    while (!pendingStates.isEmpty()) {
+    }
+    return null;
+  }
+</code>
+Now all the initial states have been pushed onto the pending states queue and marked visited.
+Here is the rest of the BFS algorithm, a loop that runs in ''checkSafety()'' until the pending state queue is empty:
+<code java [highlight_lines_extra="2,3,5,6,7,8,9,10"]>
+    while (!pendingStates.isEmpty()) {
+      Map<String, Object> current = pendingStates.remove();
+      interpreter.goToState(current);
+      for (Map<String, Object> next : interpreter.getNextStates(next.name, next.body)) {
+        if (!predecessors.containsKey(next)) {
+          predecessors.put(next, current);
+          pendingStates.add(next);
+        }
+      }
+    }
+</code>
+This will correctly explore the state space in breadth-first order.
+But to what end?
+===== Checking the Invariants =====
+Here we ensure the invariants hold in every discovered state.
+There is a minor design decision to be made: do we check the invariants upon first encountering a state, or later after popping it from the pending state queue?
+The latter turns out to be simpler because no special logic is necessary for the initial states, so that is what we do; add the highlighted code to ''checkSafety()'':
+<code java [highlight_lines_extra="4,5,6,7,8"]>
+    while (!pendingStates.isEmpty()) {
+      Map<String, Object> current = pendingStates.remove();
+      interpreter.goToState(current);
+      for (Stmt.OpDef invariant : invariants) {
+        if (!(boolean)invariant.body.accept(interpreter)) {
+          return reconstructStateTrace(predecessors, current, invariant);
+        }
+      }
+</code>
+If an invariant fails then we return a state trace!
+How do we construct that trace?
+Here is how to implement the ''reconstructStateTrace()'' helper for the ''ModelChecker'' class; first, use the ''predecessors'' graph to walk backward from the failing state to an initial state, then reverse the list of states:
+<code java>
+  List<Map<String, Object>> reconstructStateTrace(
+      Map<Map<String, Object>, Map<String, Object>> predecessors,
+      Map<String, Object> state,
+      Stmt.OpDef invariant
+  ) {
+    List<Map<String, Object>> trace = new ArrayList<>();
+    Map<String, Object> predecessor = state;
+    do {
+      trace.add(predecessor);
+      predecessor = predecessors.get(predecessor);
+    } while (predecessor != null);
+    trace =  trace.reversed();
+  }
+</code>
+Then, convert the list of states into a ''StateTrace'' object, augmenting the list of states with information about the failed invariant and the action taken at each step:
+<code java [highlight_lines_extra="3,4,5,6,7,8,10"]>
+    trace = trace.reversed();
+    List<Step> steps = new ArrayList<>();
+    Stmt.OpDef action = init;
+    for (Map<String, Object> nextState : trace) {
+      steps.add(new Step(action.name.lexeme, nextState));
+      action = next;
+    }
+    return new StateTrace(invariant.name.lexeme, steps);
+  }
+</code>
+Done!
+We have successfully implemented a TLA⁺ model-checker for safety properties!
+===== Hooking Up the Front-End =====
+Now we modify ''TlaPlus.java'' to run the model-checker when given a TLA⁺ source file.
+In past chapters we've focused on running TLA⁺ in a REPL where users can evaluate expressions and transition between states.
+Full TLA⁺ source files cannot be run as programs; all we can do is model-check them.
+The simplest place to call the model-checker is at the bottom of the ''run()'' method in the ''TlaPlus'' class; add this code:
+<code java [highlight_lines_extra="1,2,3,4,5,6,7,8,9"]>
+    if (!replMode) {
+      ModelChecker mc = new ModelChecker(interpreter, statements);
+      ModelChecker.StateTrace trace = mc.checkSafety();
+      System.out.println(
+          trace == null
+          ? "Invariants hold on state space."
+          : "Invariants do not hold; trace:\n" + trace
+      );
+    }
+  }
+</code>
+Now we can model-check TLA⁺ specs!
+What's a good first example?
+The traditional "hello world" model-checking problem is the water jugs puzzle from the movie Die Hard 3, which you can watch [[https://www.youtube.com/watch?v=BVtQNK_ZUJg|here]].
+I rewrote the [[https://github.com/tlaplus/Examples/blob/a3ecae105ce41d4ed50bc960d50c9adf36b446f3/specifications/DieHard/DieHarder.tla|Generalized Die Hard]] puzzle spec in our minimal TLA⁺ language subset; here it is:
+<code haskell>
+Jug == 1 .. 2
+Capacity == [
+  j \in Jug |->
+      IF j = 1 THEN 3
+      ELSE IF j = 2 THEN 5
+      ELSE 0
+]
+Goal == 4
+VARIABLE contents
+Min(m, n) == IF m < n THEN m ELSE n
+FillJug(target) ==
+  contents' = [
+    j \in Jug |->
+      IF j = target THEN Capacity[j] ELSE contents[j]
+  ]
+EmptyJug(target) ==
+  contents' = [
+    j \in Jug |->
+      IF j = target THEN 0 ELSE contents[j]
+  ]
+JugToJug(from, to) ==
+  /\ ~(from = to)
+  /\ contents' = [
+      j \in Jug |->
+        IF j = from THEN
+          contents[j] - Min(contents[from], Capacity[to] - contents[to])
+        ELSE IF j = to THEN
+          contents[j] + Min(contents[from], Capacity[to] - contents[to])
+        ELSE
+          contents[j]
+    ]
+TypeOK == \A j \in Jug : contents[j] \in 0 .. Capacity[j]
+Init == contents = [j \in Jug |-> 0]
+Next ==
+  \E j \in Jug :
+    \/ FillJug(j)
+    \/ EmptyJug(j)
+    \/ \E k \in Jug : JugToJug(j, k)
+Inv == \A j \in Jug : ~(contents[j] = Goal)
+</code>
+You can vary the problem definition by modifying the definition of ''Jug'' and the ''Capacity'' map.
+As-is, it checks the classic Die Hard jugs puzzle with one 3-gallon jug and one 5-gallon jug.
+We set the invariant to assert that no jug will every contain 4 gallons of water.
+When run on this spec, our model-checker spits out a state trace showing how to get 4 gallons of water in the 5-gallon jug!
+After all the preliminary work, this chapter was surprisingly short.
+We have now implemented the core of a minimal TLA⁺ model-checker for safety properties.
+One chapter remains, clarifying how operator parameters interact with the prime operator.
+It's important to understand, although somewhat optional to implement.
+Read it [[creating:closures|here]]!
+====== Challenges ======
+Here are some optional challenges to flesh out your TLA⁺ model-checker, roughly ranked from simplest to most difficult.
+You should save a copy of your code before attempting these.
+  - The state trace presentation leaves something to be desired; override the ''toString()'' method on the ''StateTrace'' and ''Step'' records to give a more readable presentation of the state trace.
+  - To save on memory, real finite-state model-checkers like TLC don't store the entire state in the ''predecessors'' map; instead, they store 64-bit hashes of each state. It is very important that hash collisions (two separate states hashing to the same value) never occur, or the correctness of the model-checker becomes compromised. Java provides a built-in ''hashCode()'' method for each object that returns a 32-bit ''int'' hash of its contents. Modify your ''predecessors'' map to use this hash code. Is this sufficient? Do you encounter any collisions?
+  - Ignoring the safety issues with using Java's built-in ''hashCode()'', modify the ''reconstructStateTrace()'' method to work with a hash-based ''predecessor'' map instead of a state-based one. How does it become more difficult?
+  - Currently, our code only specifies ''Init'' or ''Next'' as the action taken at each step in a state trace. It would be nice if it were more specific and output ''FillJug(1)'', ''EmptyJug(2)'', or ''JugToJug(1, 2)'', for example. Modify the ''reconstructStateTrace()'' method to break down the ''Init'' and ''Next'' actions to make a best effort to identify the sub-action taken. This will involve analyzing existential quantification and disjunction expressions.
+[[creating:actions|< Previous Page]] | [[creating:start#table_of_contents|Table of Contents]] | [[creating:closures|Next Page >]]